Review Request 112319: Fix network stats with new systemd interface names

Commit Hook null at kde.org
Tue Sep 10 00:22:43 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112319/#review39687
-----------------------------------------------------------


This review has been submitted with commit d09e48307f1dc204118a45a81f34102ff75fd997 by Christoph Feck to branch KDE/4.11.

- Commit Hook


On Sept. 3, 2013, 9:34 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112319/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 9:34 p.m.)
> 
> 
> Review request for kde-workspace, Solid and John Tapsell.
> 
> 
> Description
> -------
> 
> The parsing of network stats for interface names longer than 6 characters failed, because the parsing started at a fixed position. Attached patch fixes the issue.
> 
> Additionally, it was suggest to skip the wireless status field by "parsing" it, instead of assuming it is always four digits.
> 
> 
> This addresses bug 315259.
>     http://bugs.kde.org/show_bug.cgi?id=315259
> 
> 
> Diffs
> -----
> 
>   ksysguard/ksysguardd/Linux/netdev.c 2d82194 
> 
> Diff: http://git.reviewboard.kde.org/r/112319/diff/
> 
> 
> Testing
> -------
> 
> Verified by two testers, see bug 315259.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130909/21b0350f/attachment.htm>


More information about the kde-core-devel mailing list