Review Request 112319: Fix network stats with new systemd interface names

Lukáš Tinkl lukas at kde.org
Sat Sep 7 12:42:18 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112319/#review39523
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Sept. 3, 2013, 11:34 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112319/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 11:34 p.m.)
> 
> 
> Review request for kde-workspace, Solid and John Tapsell.
> 
> 
> Description
> -------
> 
> The parsing of network stats for interface names longer than 6 characters failed, because the parsing started at a fixed position. Attached patch fixes the issue.
> 
> Additionally, it was suggest to skip the wireless status field by "parsing" it, instead of assuming it is always four digits.
> 
> 
> This addresses bug 315259.
>     http://bugs.kde.org/show_bug.cgi?id=315259
> 
> 
> Diffs
> -----
> 
>   ksysguard/ksysguardd/Linux/netdev.c 2d82194 
> 
> Diff: http://git.reviewboard.kde.org/r/112319/diff/
> 
> 
> Testing
> -------
> 
> Verified by two testers, see bug 315259.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130907/c00e78ec/attachment.htm>


More information about the kde-core-devel mailing list