Review Request 112556: Move itemviews to tier2
Aurélien Gâteau
agateau at kde.org
Fri Sep 6 13:50:44 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
kdelibs.
Diffs
-----
staging/CMakeLists.txt f0b6bf0
staging/itemviews/CMakeLists.txt f5c3c8d
staging/itemviews/ItemViewsConfig.cmake.in c10f49f
staging/itemviews/autotests/CMakeLists.txt 305a6d1
staging/itemviews/autotests/klistwidgetsearchlinetest.cpp 37bcb5e
staging/itemviews/src/CMakeLists.txt 353a413
staging/itemviews/src/kcategorizedsortfilterproxymodel.h a21e7ca
staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp c8b652d
staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h eb1a67b
staging/itemviews/src/kcategorizedview.h c8035c5
staging/itemviews/src/kcategorizedview.cpp 35fafae
staging/itemviews/src/kcategorizedview_p.h 4c175fb
staging/itemviews/src/kcategorydrawer.h 3665457
staging/itemviews/src/kcategorydrawer.cpp 0fb857e
staging/itemviews/src/kextendableitemdelegate.h 386730d
staging/itemviews/src/kextendableitemdelegate.cpp f7515ce
staging/itemviews/src/kfilterproxysearchline.h 85059d7
staging/itemviews/src/kfilterproxysearchline.cpp c8ccf89
staging/itemviews/src/klistwidgetsearchline.h f38dc83
staging/itemviews/src/klistwidgetsearchline.cpp 2961df9
staging/itemviews/src/ktreewidgetsearchline.h 3570080
staging/itemviews/src/ktreewidgetsearchline.cpp 050bf27
staging/itemviews/src/kwidgetitemdelegate.h f59dc10
staging/itemviews/src/kwidgetitemdelegate.cpp ff7bdb1
staging/itemviews/src/kwidgetitemdelegate_p.h 896fc2d
staging/itemviews/src/kwidgetitemdelegatepool.cpp c4dd714
staging/itemviews/src/kwidgetitemdelegatepool_p.h f632d40
staging/itemviews/tests/CMakeLists.txt 32b0158
staging/itemviews/tests/kcategorizedviewtest.cpp 116278c
staging/itemviews/tests/ktreewidgetsearchlinetest.h 77fd758
staging/itemviews/tests/ktreewidgetsearchlinetest.cpp 74992ee
staging/itemviews/tests/kwidgetitemdelegatetest.cpp cfca1f9
tier2/CMakeLists.txt 62faacb
tier2/itemviews/CMakeLists.txt PRE-CREATION
tier2/itemviews/ItemViewsConfig.cmake.in PRE-CREATION
tier2/itemviews/autotests/CMakeLists.txt PRE-CREATION
tier2/itemviews/autotests/klistwidgetsearchlinetest.cpp PRE-CREATION
tier2/itemviews/src/CMakeLists.txt PRE-CREATION
tier2/itemviews/src/kcategorizedsortfilterproxymodel.h PRE-CREATION
tier2/itemviews/src/kcategorizedsortfilterproxymodel.cpp PRE-CREATION
tier2/itemviews/src/kcategorizedsortfilterproxymodel_p.h PRE-CREATION
tier2/itemviews/src/kcategorizedview.h PRE-CREATION
tier2/itemviews/src/kcategorizedview.cpp PRE-CREATION
tier2/itemviews/src/kcategorizedview_p.h PRE-CREATION
tier2/itemviews/src/kcategorydrawer.h PRE-CREATION
tier2/itemviews/src/kcategorydrawer.cpp PRE-CREATION
tier2/itemviews/src/kextendableitemdelegate.h PRE-CREATION
tier2/itemviews/src/kextendableitemdelegate.cpp PRE-CREATION
tier2/itemviews/src/kfilterproxysearchline.h PRE-CREATION
tier2/itemviews/src/kfilterproxysearchline.cpp PRE-CREATION
tier2/itemviews/src/klistwidgetsearchline.h PRE-CREATION
tier2/itemviews/src/klistwidgetsearchline.cpp PRE-CREATION
tier2/itemviews/src/ktreewidgetsearchline.h PRE-CREATION
tier2/itemviews/src/ktreewidgetsearchline.cpp PRE-CREATION
tier2/itemviews/src/kwidgetitemdelegate.h PRE-CREATION
tier2/itemviews/src/kwidgetitemdelegate.cpp PRE-CREATION
tier2/itemviews/src/kwidgetitemdelegate_p.h PRE-CREATION
tier2/itemviews/src/kwidgetitemdelegatepool.cpp PRE-CREATION
tier2/itemviews/src/kwidgetitemdelegatepool_p.h PRE-CREATION
tier2/itemviews/tests/CMakeLists.txt PRE-CREATION
tier2/itemviews/tests/kcategorizedviewtest.cpp PRE-CREATION
tier2/itemviews/tests/ktreewidgetsearchlinetest.h PRE-CREATION
tier2/itemviews/tests/ktreewidgetsearchlinetest.cpp PRE-CREATION
tier2/itemviews/tests/kwidgetitemdelegatetest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112556/diff/
Testing
-------
Builds and passes tests when build from kdelibs and standalone.
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130906/1aee0777/attachment.htm>
More information about the kde-core-devel
mailing list