Review Request 112529: By default hide SMB shares that end with $

[Dawit Alemayehu]

> On Sept. 6, 2013, 11:04 a.m., Mark Gaiser wrote:
> > kioslave/smb/kio_smb_browse.cpp, lines 348-354
> > <http://git.reviewboard.kde.org/r/112529/diff/1/?file=187202#file187202line348>
> >
> >     This - while most was there already - seems odd to me. Your other code catches IPC$, ADMIN$, printer$ and print$ (because of the "$") so i think you can trim this down to just "." and ".." and then just break out of the current loop interation.

All of them were there already. I did not add any new ones. I simply moved them around. Anyhow, I completely misread what Windows administrative shares meant. I thought the drive letters that ended with $ were different. That is why I kept the existing code and did the patch the way I did it. Upon a second review all so called hidden shares, those that end with $, are administrative shares ; so I am going to change this to do exactly as you suggested above.


On Sept. 6, 2013, 11:04 a.m., Dawit Alemayehu wrote:
> > I don't know much in the samba department, but just happened to touch the exact same code a few days ago when porting it to Qt5/KF5 - which is still waiting for someone to review it btw ;)

I saw that. I was going to comment on it but I forgot. I will do that now.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112529/#review39456
-----------------------------------------------------------


On Sept. 6, 2013, 12:35 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112529/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 12:35 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The attached patch marks all files, directories, shares etc as hidden by default. That what the GUI applications can correctly hide them and only make them visible when the "Show Hidden Files" option is checked.
> 
> 
> This addresses bug 197903.
>     http://bugs.kde.org/show_bug.cgi?id=197903
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
> 
> Diff: http://git.reviewboard.kde.org/r/112529/diff/
> 
> 
> Testing
> -------
> 
> Tested against shares from a Windows 7 machine.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130906/1594498b/attachment.htm>