Review Request 112529: By default hide SMB shares that end with $

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112529/#review39456
-----------------------------------------------------------



kioslave/smb/kio_smb_browse.cpp
<http://git.reviewboard.kde.org/r/112529/#comment29069>

    This - while most was there already - seems odd to me. Your other code catches IPC$, ADMIN$, printer$ and print$ (because of the "$") so i think you can trim this down to just "." and ".." and then just break out of the current loop interation. 



kioslave/smb/kio_smb_browse.cpp
<http://git.reviewboard.kde.org/r/112529/#comment29068>

    Move this code up above the if-elseif-elseif-.... Around the line: udsentry.insert( KIO::UDSEntry::UDS_NAME, udsName );
    
    Doing that means that you only have to add this code once instead of 4 times (like you did now). You can remove the other ones.



kioslave/smb/kio_smb_browse.cpp
<http://git.reviewboard.kde.org/r/112529/#comment29070>

    See other comment about the same code.



kioslave/smb/kio_smb_browse.cpp
<http://git.reviewboard.kde.org/r/112529/#comment29071>

    See other comment about the same code.



kioslave/smb/kio_smb_browse.cpp
<http://git.reviewboard.kde.org/r/112529/#comment29072>

    See other comment about the same code.


I don't know much in the samba department, but just happened to touch the exact same code a few days ago when porting it to Qt5/KF5 - which is still waiting for someone to review it btw ;)

- Mark Gaiser


On Sept. 5, 2013, 1:32 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112529/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 1:32 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The attached patch marks all files, directories, shares etc as hidden by default. That what the GUI applications can correctly hide them and only make them visible when the "Show Hidden Files" option is checked.
> 
> 
> This addresses bug 197903.
>     http://bugs.kde.org/show_bug.cgi?id=197903
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
> 
> Diff: http://git.reviewboard.kde.org/r/112529/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130906/8b1d80a4/attachment.htm>