Review Request 101348: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

[Jeffery MacEachern]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101348/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 5:54 p.m.)


Status
------

This change has been discarded.


Review request for kdelibs, David Faure, Kevin Ottens, and Ivan Čukić.


Repository: kdelibs


Description
-------

Adds an "Only show in this Activity" option to the KFilePlaces Widget and support in the underlying model code. Currently only "one activity"/"all activities" are supported as choices; I think this should be sufficient, and anything more complicated would be hard to make usable.


Diffs
-----

  kfile/CMakeLists.txt ceae140 
  kfile/kfileplaceeditdialog.h d5b030a 
  kfile/kfileplaceeditdialog.cpp d798b4d 
  kfile/kfileplacesmodel.h b3dd821 
  kfile/kfileplacesmodel.cpp b037084 
  kfile/kfileplacesview.cpp 6a343b3 

Diff: http://git.reviewboard.kde.org/r/101348/diff/


Testing
-------

Tested on Project Neon/Kubuntu Natty. Created several activities, added Place bookmarks, set them to only show in the current activity, and switched activities. Everything worked as intended. EDIT: one small known issue - the OnlyInActivity setting doesn't take when the bookmark is first created; you have to hit Edit and re-check the box.


Thanks,

Jeffery MacEachern

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131029/01d86677/attachment.htm>