Review Request 101348: Add Activity Awareness to KFilePlaces* Widget (OnlyInActivity)

[Kevin Ottens]

> On Oct. 25, 2011, 10:05 a.m., Kai Uwe Broulik wrote:
> > Is there any progress on this?
> > I’d propose you enhance the feature to make the individual activities selectable, i.e. you can choose in which particular activities an entry should appear, similar to KWin’s "Activity" menu in the window title where you can assign a window to multiple activities.
> 
> Aaron J. Seigo wrote:
>     unfortunately, this can't only be done in the frameworks branch, and even then not quite yet. kactivities has already been broken out, and while it should be a valid dependency for the kfile library, kdelibs is not yet broken up so it would create a circular build dependency at the moment (as kactivities relies on libkdecore).
>     
>     when it does go in, however, i agree with Jeff that adding a specific activity chooser would be ungainly. it also would not fit in with the rest of this dialog which has entries like "only in this application" (rather than "in the following applications...")
> 
> Jeffery MacEachern wrote:
>     Thank you for the info, Aaron. School (and life) have prevented me from doing much of anything for the last several months, so if somebody else wants to pick this up, please feel free. I don't know when I'll have time again.
> 
> David Faure wrote:
>     If we (=someone) make a frameworks branch for kactivities, it should be quite simple to port that away from kdecore (I suppose it was mostly using KPluginLoader, which has now moved to the kservice framework). So this might just be a matter of updating a few CMakeLists.txt files.
> 
> Aaron J. Seigo wrote:
>     making a frameworks branch in the kactivities repo is fine. the library should indeed be easy to port.
>     
>     the daemon process will need a bit more effort, but many of its needs are already taken care of in the frameworks branch of kdelibs (such as the dbus service classes)

Still no activity on that patch for a year, should it be discarded?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101348/#review7592
-----------------------------------------------------------


On June 1, 2011, 6:07 a.m., Jeffery MacEachern wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101348/
> -----------------------------------------------------------
> 
> (Updated June 1, 2011, 6:07 a.m.)
> 
> 
> Review request for kdelibs, David Faure, Kevin Ottens, and Ivan Čukić.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Adds an "Only show in this Activity" option to the KFilePlaces Widget and support in the underlying model code. Currently only "one activity"/"all activities" are supported as choices; I think this should be sufficient, and anything more complicated would be hard to make usable.
> 
> 
> Diffs
> -----
> 
>   kfile/CMakeLists.txt ceae140 
>   kfile/kfileplaceeditdialog.h d5b030a 
>   kfile/kfileplaceeditdialog.cpp d798b4d 
>   kfile/kfileplacesmodel.h b3dd821 
>   kfile/kfileplacesmodel.cpp b037084 
>   kfile/kfileplacesview.cpp 6a343b3 
> 
> Diff: http://git.reviewboard.kde.org/r/101348/diff/
> 
> 
> Testing
> -------
> 
> Tested on Project Neon/Kubuntu Natty. Created several activities, added Place bookmarks, set them to only show in the current activity, and switched activities. Everything worked as intended. EDIT: one small known issue - the OnlyInActivity setting doesn't take when the bookmark is first created; you have to hit Edit and re-check the box.
> 
> 
> Thanks,
> 
> Jeffery MacEachern
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131014/0e3abf8a/attachment.htm>