Review Request 110662: Add dbus signal to ksmserver, used for requesting session saving from services.

[Simon Persson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110662/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 5:53 p.m.)


Review request for kde-workspace, Aaron J. Seigo, Ivan Čukić, and Thomas Lübking.


Repository: kde-workspace


Description
-------

Support session saving in the activity manager service, which can be started before ksmserver and therefore it could potentially not have contact with ksmserver over ICE. Do this by emitting a dbus signal when the current session should be saved.
Only support for "save state" or "local", which is used for saving current window positions and such, not the "commit state" or "global" which is used to save files the user has opened. A service like the activity manager should only need the former since it is not an application.

Separate review for adding support in kamd.


Diffs
-----

  ksmserver/org.kde.KSMServerInterface.xml 9dad130 
  ksmserver/server.h 3b993c5 
  ksmserver/shutdown.cpp d1db3ff 

Diff: http://git.reviewboard.kde.org/r/110662/diff/


Testing
-------

Tested by running a full kde session compiled from master, logging of the signal with qbusviewer.
With "restore previous session" set: signal emitted at all logouts. "save session" button is not available.
With "restore manually saved session" set: signal emitted on manual "save session" activation but not on log out.


Thanks,

Simon Persson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131029/ef1fa0e0/attachment.htm>