<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110662/">http://git.reviewboard.kde.org/r/110662/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Aaron J. Seigo, Ivan Čukić, and Thomas Lübking.</div>
<div>By Simon Persson.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2013, 5:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Support session saving in the activity manager service, which can be started before ksmserver and therefore it could potentially not have contact with ksmserver over ICE. Do this by emitting a dbus signal when the current session should be saved.
Only support for "save state" or "local", which is used for saving current window positions and such, not the "commit state" or "global" which is used to save files the user has opened. A service like the activity manager should only need the former since it is not an application.
Separate review for adding support in kamd.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by running a full kde session compiled from master, logging of the signal with qbusviewer.
With "restore previous session" set: signal emitted at all logouts. "save session" button is not available.
With "restore manually saved session" set: signal emitted on manual "save session" activation but not on log out.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/org.kde.KSMServerInterface.xml <span style="color: grey">(9dad130)</span></li>
<li>ksmserver/server.h <span style="color: grey">(3b993c5)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(d1db3ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110662/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>