Review Request 113479: fix kshareddatacache on windows
Commit Hook
null at kde.org
Mon Oct 28 20:08:04 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113479/#review42552
-----------------------------------------------------------
This review has been submitted with commit 23e1b357115cc3b5eb699f93b22340529e5dd5eb by Sune Vuorela to branch frameworks.
- Commit Hook
On Oct. 28, 2013, 10:07 a.m., Sune Vuorela wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113479/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 10:07 a.m.)
>
>
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.
>
> Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.
>
>
> Diffs
> -----
>
> tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31
> tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d
>
> Diff: http://git.reviewboard.kde.org/r/113479/diff/
>
>
> Testing
> -------
>
> Test suite passes
>
>
> Thanks,
>
> Sune Vuorela
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131028/0ed6aa63/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
More information about the kde-core-devel
mailing list