Review Request 113479: fix kshareddatacache on windows

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113479/#review42533
-----------------------------------------------------------

Ship it!


Looks good from here, the test you added even has a matching counterpart in the Linux version, so I hope I didn't write the Windows code. ;)

- Michael Pyne


On Oct. 28, 2013, 10:07 a.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113479/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 10:07 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> fix kshareddatacache on windows to at least not be a way to have a bytearray roundtrip.
> 
> Also, the windows implementation is currently only a in-memory one, so don't test on windows if there is a file written.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/autotests/kshareddatacachetest.cpp a4484560735f9096ecdac26b3c539394602e0f31 
>   tier1/kcoreaddons/src/lib/caching/kshareddatacache_win.cpp cdc6536b56888a615e74960bf1b55fb12cc3e70d 
> 
> Diff: http://git.reviewboard.kde.org/r/113479/diff/
> 
> 
> Testing
> -------
> 
> Test suite passes
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131028/5b2cbcd4/attachment.htm>