Review Request 102391: Don't hang when determining MIME type of corrupted files

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102391/
-----------------------------------------------------------

(Updated Oct. 27, 2013, 7:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 280446
    http://bugs.kde.org/show_bug.cgi?id=280446


Repository: kdelibs


Description
-------

If KMimeTypeRepository::findFromContent() tries to determine MIME from a file that cannot be read, such as on a corrupted optical disc, a read attempt is made in KMimeMagicMatch::match() for every available rule, resulting in UI hangs (e.g. file dialogs, dolphin) for tens of minutes (see https://bugs.kde.org/show_bug.cgi?id=280446 for more details).

I've submitted this patch here on behalf of Miroslav ?os, who has submitted the bug-report and also has written the patch.


Diffs
-----

  kdecore/services/kmimetype.cpp 955bf62 
  kdecore/services/kmimetyperepository.cpp 6ff3d16 

Diff: http://git.reviewboard.kde.org/r/102391/diff/


Testing
-------


Thanks,

Peter Penz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131027/1900507f/attachment.htm>