Review Request 111238: Remove <iterator>.end() calls from iteration loops in KDirLister

[Albert Astals Cid]

> On June 26, 2013, 10:56 a.m., David Faure wrote:
> > The change itself looks OK, but all it will do is create a gigantic merge conflict for me in frameworks... is that really worth it?
> > 
> > I think it would be better to make such cleanups in frameworks directly.

Dawit, David, what should we do here? Discard the commit? Retarget it to frameworks? Personally i'm with David that it doesn't seem like a huge "speed" win and if's going to cause lots of conflicts it may be better to target frameworks.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111238/#review35114
-----------------------------------------------------------


On June 26, 2013, 4:44 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111238/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 4:44 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch removes <iterator>.end() from for and while loops in kdirlister.cpp. I made the change only when it can be done safely. The for loops that had the .end() calls in them were replaced with a Q_FOREACH statement.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdirlister.cpp d66c324 
> 
> Diff: http://git.reviewboard.kde.org/r/111238/diff/
> 
> 
> Testing
> -------
> 
> Run the unit test.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131027/1c9eb5bc/attachment.htm>