Review Request 113413: Improved Keyboard Layout Preview

[shivam makkar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113413/
-----------------------------------------------------------

(Updated Oct. 26, 2013, 1:04 p.m.)


Review request for KDE Runtime, kde-workspace and Andriy Rysin.


Changes
-------

Fixed the position of names on keys.
I really forgot about the preview in different resolutions, thanks Christoph Feck for reminding :).
now the size of dialog changes as per screen resolution, the scalefactor, which was constant earlier, changes as per resolution of screen.


Repository: kde-workspace


Description
-------

Improved keyboard layout preview 
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names.
my GSoC-13 project !


Diffs (updated)
-----

  kcontrol/keyboard/preview/geometry_components.cpp 65c47f0 
  kcontrol/keyboard/preview/kbpreviewframe.h 7cfefa5 
  kcontrol/keyboard/preview/kbpreviewframe.cpp 903a4f0 
  kcontrol/keyboard/preview/keyboardpainter.cpp a740d44 

Diff: http://git.reviewboard.kde.org/r/113413/diff/


Testing
-------


File Attachments (updated)
----------------

English layout on default geometry
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/25/48fead43-1cfc-4cce-9d37-0943b3e780cd__snapshot11.jpg
English layout on microsoft natural geometry
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/25/2bfcbe59-d152-4bfc-8760-b40c2e4d5181__snapshot12.jpg
french layout default geometry
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/19226ef7-53fd-4a43-af48-94731eca2cb5__snapshot13.jpg
Fixed position of the key names
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/cc9cae25-2366-4978-98b0-d83b41eabc09__snapshot14.jpg


Thanks,

shivam makkar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131026/fc205e68/attachment.htm>