Review Request 113413: Improved Keyboard Layout Preview

shivam makkar amourphious1992 at
Sat Oct 26 14:04:02 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 26, 2013, 1:04 p.m.)

Review request for KDE Runtime, kde-workspace and Andriy Rysin.


Fixed the position of names on keys.
I really forgot about the preview in different resolutions, thanks Christoph Feck for reminding :).
now the size of dialog changes as per screen resolution, the scalefactor, which was constant earlier, changes as per resolution of screen.

Repository: kde-workspace


Improved keyboard layout preview 
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names.
my GSoC-13 project !

Diffs (updated)

  kcontrol/keyboard/preview/geometry_components.cpp 65c47f0 
  kcontrol/keyboard/preview/kbpreviewframe.h 7cfefa5 
  kcontrol/keyboard/preview/kbpreviewframe.cpp 903a4f0 
  kcontrol/keyboard/preview/keyboardpainter.cpp a740d44 



File Attachments (updated)

English layout on default geometry
English layout on microsoft natural geometry
french layout default geometry
Fixed position of the key names


shivam makkar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list