<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113413/">http://git.reviewboard.kde.org/r/113413/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, kde-workspace and Andriy Rysin.</div>
<div>By shivam makkar.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2013, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the position of names on keys.
I really forgot about the preview in different resolutions, thanks Christoph Feck for reminding :).
now the size of dialog changes as per screen resolution, the scalefactor, which was constant earlier, changes as per resolution of screen.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improved keyboard layout preview
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names.
my GSoC-13 project !</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/preview/geometry_components.cpp <span style="color: grey">(65c47f0)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.h <span style="color: grey">(7cfefa5)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.cpp <span style="color: grey">(903a4f0)</span></li>
<li>kcontrol/keyboard/preview/keyboardpainter.cpp <span style="color: grey">(a740d44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113413/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/25/48fead43-1cfc-4cce-9d37-0943b3e780cd__snapshot11.jpg">English layout on default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/25/2bfcbe59-d152-4bfc-8760-b40c2e4d5181__snapshot12.jpg">English layout on microsoft natural geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/19226ef7-53fd-4a43-af48-94731eca2cb5__snapshot13.jpg">french layout default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/cc9cae25-2366-4978-98b0-d83b41eabc09__snapshot14.jpg">Fixed position of the key names</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>