Review Request 113819: don't install dbus interface file

[Jonathan Riddell]

> On Nov. 12, 2013, 11:26 p.m., Martin Klapetek wrote:
> > Actually the file is not equivalent, the signal names were changed and one signal was removed completely.

all the more reason not to ship it :)


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113819/#review43560
-----------------------------------------------------------


On Nov. 12, 2013, 4:47 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113819/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 4:47 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> dbus interface files are only used when compiling code against that interface, but there is nothing which uses this interface, we don't advertise it as a developer interface so it might change without warning and this file clashes with the equivalent file in KDE 4 so it shouldn't be installed (the debian/kubuntu packages don't install it).
> 
> 
> Diffs
> -----
> 
>   ktimezoned/CMakeLists.txt ce8f742 
> 
> Diff: http://git.reviewboard.kde.org/r/113819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131113/2d62ba11/attachment.htm>