Review Request 113819: don't install dbus interface file
Martin Klapetek
martin.klapetek at gmail.com
Tue Nov 12 23:26:30 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113819/#review43560
-----------------------------------------------------------
Actually the file is not equivalent, the signal names were changed and one signal was removed completely.
- Martin Klapetek
On Nov. 12, 2013, 4:47 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113819/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 4:47 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> dbus interface files are only used when compiling code against that interface, but there is nothing which uses this interface, we don't advertise it as a developer interface so it might change without warning and this file clashes with the equivalent file in KDE 4 so it shouldn't be installed (the debian/kubuntu packages don't install it).
>
>
> Diffs
> -----
>
> ktimezoned/CMakeLists.txt ce8f742
>
> Diff: http://git.reviewboard.kde.org/r/113819/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131112/c0a53137/attachment.htm>
More information about the kde-core-devel
mailing list