Review Request 110423: Searchprovider dialog: add insert query placeholder button

[Maarten De Meyer]

> On May 17, 2013, 10:36 p.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/searchproviderdlg.cpp, line 185
> > <http://git.reviewboard.kde.org/r/110423/diff/1/?file=143674#file143674line185>
> >
> >     Why not simply disable the button on a FocusOut event for m_dlg.leQuery ? That way you do not need to install an event filter on all the edits.

Because the focusout event is called before the button signal is emitted. So when clicking the button it gets disabled and does nothing :)
But I dropped the eventfilter code in the new version


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110423/#review32716
-----------------------------------------------------------


On May 21, 2013, 3:22 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110423/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 3:22 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> This adds a 'Insert query placeholder' button to the add/modify web shortcut dialog.
> -Clicking this button inserts \{@} in the shortcut URL lineEdit.
> -The button is only enabled when the shortcut URL lineEdit has focus.
> 
> This makes it easy to add new web shortcuts. Users don't have to remember and type the query placeholder.
> 
> The eventfilter complicates this patch a lot. But there is no slot to detect if a lineedit has focus.
> We could drop it but it looks messy when the button is always enabled.
> I feel the tooltip text can be improved. Any suggestions from a native English speaker?
> 
> 
> This addresses bug 146879.
>     http://bugs.kde.org/show_bug.cgi?id=146879
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/ikws/searchproviderdlg.h e931e11 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f 
>   kurifilter-plugins/ikws/searchproviderdlg_ui.ui d75ac5b 
> 
> Diff: http://git.reviewboard.kde.org/r/110423/diff/
> 
> 
> Testing
> -------
> 
> Added a new shortcut.
> Changed focus to and from different widgets.
> Inserted placeholder at the end of the link and in the middle.
> Modified a shortcut.
> 
> 
> File Attachments
> ----------------
> 
> Before - After screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/before-After.png
> Berfore vs After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130521/c2cadb81/attachment.htm>