Review Request 110423: Searchprovider dialog: add insert query placeholder button

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110423/
-----------------------------------------------------------

(Updated May 21, 2013, 3:22 p.m.)


Review request for KDE Runtime.


Changes
-------

Changed the dialog as you requested.
-No more eventfilter code :)
-Button next to the lineEdit (see screenshot, I have created the first option but could change to the second to better align the lineEdits)
-The layout is changed to a qgridlayout.
-'Insert query placholder' tooltip


Description
-------

This adds a 'Insert query placeholder' button to the add/modify web shortcut dialog.
-Clicking this button inserts \{@} in the shortcut URL lineEdit.
-The button is only enabled when the shortcut URL lineEdit has focus.

This makes it easy to add new web shortcuts. Users don't have to remember and type the query placeholder.

The eventfilter complicates this patch a lot. But there is no slot to detect if a lineedit has focus.
We could drop it but it looks messy when the button is always enabled.
I feel the tooltip text can be improved. Any suggestions from a native English speaker?


This addresses bug 146879.
    http://bugs.kde.org/show_bug.cgi?id=146879


Diffs (updated)
-----

  kurifilter-plugins/ikws/searchproviderdlg.h e931e11 
  kurifilter-plugins/ikws/searchproviderdlg.cpp 5f40f5f 
  kurifilter-plugins/ikws/searchproviderdlg_ui.ui d75ac5b 

Diff: http://git.reviewboard.kde.org/r/110423/diff/


Testing
-------

Added a new shortcut.
Changed focus to and from different widgets.
Inserted placeholder at the end of the link and in the middle.
Modified a shortcut.


File Attachments (updated)
----------------

Before - After screenshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/before-After.png
Berfore vs After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/21/before-After2.png


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130521/9b6941e3/attachment.htm>