Review Request 110367: Add JoinTheGame menu entry
Albert Astals Cid
aacid at kde.org
Wed May 8 23:22:12 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110367/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
Patch by Pau ages ago, Lydia wants to push for it again.
Note that i still find it ugly, but i'm not the kdeui maintainer, so i'll leave it to someone else to discuss.
Not sure if the StandardAction enum addition should be at the end in case someone is storing those enums in a file or something.
Diffs
-----
kdecore/doc/README.kiosk b95002d
kdeui/CMakeLists.txt b439e04
kdeui/actions/kstandardaction.h 3064301
kdeui/actions/kstandardaction.cpp 7de0c6f
kdeui/actions/kstandardaction_p.h b8f8df1
kdeui/dialogs/jointhegame.png PRE-CREATION
kdeui/dialogs/kaboutkdedialog_p.cpp b9728bf
kdeui/dialogs/kjointhegamedialog_p.h PRE-CREATION
kdeui/dialogs/kjointhegamedialog_p.cpp PRE-CREATION
kdeui/shortcuts/kstandardshortcut.h b31e45c
kdeui/shortcuts/kstandardshortcut.cpp 669f750
kdeui/widgets/khelpmenu.h 3389068
kdeui/widgets/khelpmenu.cpp f547c46
kdeui/xmlgui/ui_standards.rc a0f5bed
Diff: http://git.reviewboard.kde.org/r/110367/diff/
Testing
-------
Ran okular, saw the new menu entry, it did stuff.
Ran ksnapshot (that doesn't use xmlgui), saw the new menu entry, it did the same stuff.
Thanks,
Albert Astals Cid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130508/4d66e253/attachment.htm>
More information about the kde-core-devel
mailing list