Review Request 110090: Clean up kickoff from stale bits

Raphael Kubo da Costa rakuco at FreeBSD.org
Wed May 8 15:57:23 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110090/#review32262
-----------------------------------------------------------

Ship it!


Thanks for the cleanup. You might also want to remove the references to Strigi in DESIGN-GOALS and STATUS-TODO, but I guess they're very outdated anyway. Please include a descriptive commit message explaining that this patch also fixes build problems for people without Strigi.

- Raphael Kubo da Costa


On April 20, 2013, 1:13 a.m., Max Brazhnikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110090/
> -----------------------------------------------------------
> 
> (Updated April 20, 2013, 1:13 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> kickoff links to strigiqtdbusclient, but Strigi is not used since svn r1018482.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/CMakeLists.txt e9e2888 
>   plasma/desktop/applets/kickoff/core/config-kickoff-applets.h.cmake cecf380 
> 
> Diff: http://git.reviewboard.kde.org/r/110090/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Max Brazhnikov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130508/3787a1ee/attachment.htm>


More information about the kde-core-devel mailing list