Review Request 110327: KMessageWidget: Remove decoration icon

Aurélien Gâteau agateau at kde.org
Mon May 6 21:59:49 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/
-----------------------------------------------------------

(Updated May 6, 2013, 10:59 p.m.)


Review request for Dolphin, Kate and kdelibs.


Changes
-------

Remove useless KIcon.


Description
-------

This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host.
This change also has the nice side-effect of leaving more space for the widget text.


Diffs (updated)
-----

  kdeui/widgets/kmessagewidget.cpp a52316726233a22929ce8ad3aff60b9ccc5f9b85 

Diff: http://git.reviewboard.kde.org/r/110327/diff/


Testing
-------

Tested with kmessagewidgetdemo, Dolphin and Kate.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130506/1081faf9/attachment.htm>


More information about the kde-core-devel mailing list