Review Request 110327: KMessageWidget: Remove decoration icon

[Aurélien Gâteau]

> On May 6, 2013, 9:32 p.m., Thomas Lübking wrote:
> > Semi-OT (sorry) - what makes this thing appear "on top" of things (below the toolbar) - and why?
> > In a NW gravity world, this means the UI is shifted downwards "under the users fingers" (no matter where you are, the poaint where your mouse was will be ~128px lower as soon as this appears - untriggered)
> > 
> > a) Is moving it to the bottom in the cards?
> > b) Is it in the cards for 4.11?

KMessageWidget is used like a regular widget: it appears wherever the application developer decides to place it.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32154
-----------------------------------------------------------


On May 6, 2013, 5:53 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110327/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 5:53 p.m.)
> 
> 
> Review request for Dolphin, Kate and kdelibs.
> 
> 
> Description
> -------
> 
> This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host.
> This change also has the nice side-effect of leaving more space for the widget text.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmessagewidget.cpp a52316726233a22929ce8ad3aff60b9ccc5f9b85 
> 
> Diff: http://git.reviewboard.kde.org/r/110327/diff/
> 
> 
> Testing
> -------
> 
> Tested with kmessagewidgetdemo, Dolphin and Kate.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130506/95181380/attachment.htm>