Review Request 110313: Some KUrifilter-plugin Krazy fixes

[Maarten De Meyer]

> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/ikwsopts.cpp, line 107
> > <http://git.reviewboard.kde.org/r/110313/diff/2/?file=142219#file142219line107>
> >
> >     what exactly is <nl/> ? Is this i18n specific keyword ?

Yes it is il8n semantic markup. <nl/> is a Line break, perhaps <para> tags are better here?
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics#Semantic_Tags


> On May 5, 2013, 4:09 a.m., Dawit Alemayehu wrote:
> > kurifilter-plugins/ikws/ikwsopts.cpp, line 412
> > <http://git.reviewboard.kde.org/r/110313/diff/2/?file=142219#file142219line412>
> >
> >     What is the point of using a QPointer when the parent is set to NULL ?

The parent is not NULL, it is this (third argument). The firs argument is the provider to be edited, or when creating a new provider: 0
Please correct me if I'm wrong.


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110313/#review32045
-----------------------------------------------------------


On May 4, 2013, 10:50 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110313/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 10:50 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> This fixes most of the Krazy fixes for KUrifilter-plugins.
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html
> 
> 
> Diffs
> -----
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 802b325 
>   kurifilter-plugins/localdomain/localdomainurifilter.h 894b624 
>   kurifilter-plugins/ikws/searchproviderdlg.cpp eb4b31d 
>   kurifilter-plugins/ikws/searchprovider.h 7f26ba7 
>   kurifilter-plugins/ikws/ikwsopts_ui.ui 42e9675 
>   kurifilter-plugins/ikws/ikwsopts_p.h d048f08 
>   kurifilter-plugins/ikws/ikwsopts.cpp 8ca80b6 
>   kurifilter-plugins/fixhost/fixhosturifilter.h 8603e36 
>   kurifilter-plugins/tests/kurifiltertest.cpp dd18eba 
> 
> Diff: http://git.reviewboard.kde.org/r/110313/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> Only 4 issues remaining.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130505/a616953d/attachment.htm>