<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110313/">http://git.reviewboard.kde.org/r/110313/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2013, 4:09 a.m. UTC, <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110313/diff/2/?file=142219#file142219line107" style="color: black; font-weight: bold; text-decoration: underline;">kurifilter-plugins/ikws/ikwsopts.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QVariant ProvidersModel::data(const QModelIndex& index, int role) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">107</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">"as preferred.<<span class="hl">br/><br</span>/>Preferred web shortcuts are used in "</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">107</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">"as preferred.<<span class="hl">nl</span>/>Preferred web shortcuts are used in "</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what exactly is <nl/> ? Is this i18n specific keyword ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes it is il8n semantic markup. <nl/> is a Line break, perhaps <para> tags are better here?
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics#Semantic_Tags</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2013, 4:09 a.m. UTC, <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110313/diff/2/?file=142219#file142219line412" style="color: black; font-weight: bold; text-decoration: underline;">kurifilter-plugins/ikws/ikwsopts.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FilterOptions::defaults()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SearchProviderDialo<span class="hl">g</span></span><span class="hl"> </span><span class="nf"><span class="hl">dl</span>g</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">providers</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">412</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"> </span><span class="n"><span class="hl">QPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">SearchProviderDialog</span></span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="n"><span class="hl">dlg</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="k"><span class="hl">new</span></span> <span class="n">SearchProviderDialog</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">providers</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></
pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the point of using a QPointer when the parent is set to NULL ?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The parent is not NULL, it is this (third argument). The firs argument is the provider to be edited, or when creating a new provider: 0
Please correct me if I'm wrong.</pre>
<br />
<p>- Maarten</p>
<br />
<p>On May 4th, 2013, 10:50 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated May 4, 2013, 10:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes most of the Krazy fixes for KUrifilter-plugins.
http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kde-runtime/kurifilter-plugins/index.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles.
Only 4 issues remaining.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/shorturi/kshorturifilter.cpp <span style="color: grey">(802b325)</span></li>
<li>kurifilter-plugins/localdomain/localdomainurifilter.h <span style="color: grey">(894b624)</span></li>
<li>kurifilter-plugins/ikws/searchproviderdlg.cpp <span style="color: grey">(eb4b31d)</span></li>
<li>kurifilter-plugins/ikws/searchprovider.h <span style="color: grey">(7f26ba7)</span></li>
<li>kurifilter-plugins/ikws/ikwsopts_ui.ui <span style="color: grey">(42e9675)</span></li>
<li>kurifilter-plugins/ikws/ikwsopts_p.h <span style="color: grey">(d048f08)</span></li>
<li>kurifilter-plugins/ikws/ikwsopts.cpp <span style="color: grey">(8ca80b6)</span></li>
<li>kurifilter-plugins/fixhost/fixhosturifilter.h <span style="color: grey">(8603e36)</span></li>
<li>kurifilter-plugins/tests/kurifiltertest.cpp <span style="color: grey">(dd18eba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110313/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>