Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

Commit Hook null at kde.org
Wed May 1 11:53:18 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/
-----------------------------------------------------------

(Updated May 1, 2013, 10:53 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.


Description
-------

I was getting lots of errors while moving my mouse over system tray before this patch.
Also this patch fixes a forgetten check before freeing a already undefined pixmap


Diffs
-----

  plasma/private/dialogshadows.cpp 89814ec 

Diff: http://git.reviewboard.kde.org/r/110138/diff/


Testing
-------

Looks like it is working fine


Thanks,

Ömer Fadıl Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130501/87c45159/attachment.htm>


More information about the kde-core-devel mailing list