Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/#review31830
-----------------------------------------------------------


This review has been submitted with commit ebca90e1a50435f27cbfa2e8f3e599c1c037542b by Ömer Fadıl USTA to branch KDE/4.10.

- Commit Hook


On April 30, 2013, 9:04 a.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110138/
> -----------------------------------------------------------
> 
> (Updated April 30, 2013, 9:04 a.m.)
> 
> 
> Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.
> 
> 
> Description
> -------
> 
> I was getting lots of errors while moving my mouse over system tray before this patch.
> Also this patch fixes a forgetten check before freeing a already undefined pixmap
> 
> 
> Diffs
> -----
> 
>   plasma/private/dialogshadows.cpp 89814ec 
> 
> Diff: http://git.reviewboard.kde.org/r/110138/diff/
> 
> 
> Testing
> -------
> 
> Looks like it is working fine
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130501/eee6134b/attachment.htm>