Review Request 109551: port KPtyProcess to QProcess

[Martin Tobias Holmedahl Sandsmark]

> On March 18, 2013, 7:25 a.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 180
> > <http://git.reviewboard.kde.org/r/109551/diff/1/?file=120230#file120230line180>
> >
> >     why should they? you already have the solution in the previous hunk.

Doh, I'm just a silly moose. Thanks for reminding me. :-)


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29421
-----------------------------------------------------------


On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Just a simple port of KPtyProcess away from using KProcess.
> 
> 
> Diffs
> -----
> 
>   kpty/kptyprocess.h 5e0df96 
>   kpty/kptyprocess.cpp 015a58c 
>   kpty/tests/kptyprocesstest.h 64bded0 
>   kpty/tests/kptyprocesstest.cpp 04990a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130318/0ca26915/attachment.htm>