Review Request 109551: port KPtyProcess to QProcess

Oswald Buddenhagen ossi at kde.org
Mon Mar 18 07:25:39 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29421
-----------------------------------------------------------



kpty/tests/kptyprocesstest.cpp
<http://git.reviewboard.kde.org/r/109551/#comment21968>

    why should they? you already have the solution in the previous hunk.


- Oswald Buddenhagen


On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 4:44 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Just a simple port of KPtyProcess away from using KProcess.
> 
> 
> Diffs
> -----
> 
>   kpty/kptyprocess.h 5e0df96 
>   kpty/kptyprocess.cpp 015a58c 
>   kpty/tests/kptyprocesstest.h 64bded0 
>   kpty/tests/kptyprocesstest.cpp 04990a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130318/46906107/attachment.htm>


More information about the kde-core-devel mailing list