Review Request 110459: Klipper: Allow to keep items in clipboard history

[David Faure]

> On June 26, 2013, 7:55 p.m., Lamarque Souza wrote:
> > klipper/historyitem.h, line 69
> > <http://git.reviewboard.kde.org/r/110459/diff/1/?file=144142#file144142line69>
> >
> >     add const before "bool", like this:
> >     
> >     setKeep(const bool keep)

That's rather unusual (check all of Qt, it's not done anywhere) and useless (it changes nothing, in the header file. At most having it in the .cpp means it won't be changed inside the implementation, but in the header it really serves no purpose). Some compilers might even warn about it being useless (not sure).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110459/#review35140
-----------------------------------------------------------


On May 15, 2013, 7:39 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110459/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 7:39 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> This patch allows users to prevent important items from being overwritten in the clipboard history.
> Methods keep and setKeep were added to HistoryItem. If an item has keep set to true, it will not be overwritten.
> A submenu was added to set whether an item should be kept in history.
> Even if there are more elements in the list than the maximum number of entries, the newest element copied to the clipboard will be in the clipboard item.
> In order to allow Klipper to read history files written with previous versions of Klipper, saving and loading if an item should be kept is handled in klipper.cpp and not by the item.
> 
> 
> This addresses bug 54212.
>     http://bugs.kde.org/show_bug.cgi?id=54212
> 
> 
> Diffs
> -----
> 
>   klipper/history.cpp 49e9bb0 
>   klipper/historyitem.h 6c41d5d 
>   klipper/historyitem.cpp 21fbe4e 
>   klipper/klipper.h bbfd9c9 
>   klipper/klipper.cpp cf41bd2 
>   klipper/klipperpopup.h 31beff2 
>   klipper/klipperpopup.cpp bff2c25 
>   klipper/popupproxy.h 910bd6e 
>   klipper/popupproxy.cpp 555f383 
> 
> Diff: http://git.reviewboard.kde.org/r/110459/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130626/b8eb9466/attachment.htm>