<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110459/">http://git.reviewboard.kde.org/r/110459/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 26th, 2013, 7:55 p.m. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110459/diff/1/?file=144142#file144142line69" style="color: black; font-weight: bold; text-decoration: underline;">klipper/historyitem.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="kt">void</span> <span class="nf">setKeep</span><span class="p">(</span><span class="kt">bool</span> <span class="n">keep</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add const before "bool", like this:
setKeep(const bool keep)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's rather unusual (check all of Qt, it's not done anywhere) and useless (it changes nothing, in the header file. At most having it in the .cpp means it won't be changed inside the implementation, but in the header it really serves no purpose). Some compilers might even warn about it being useless (not sure).</pre>
<br />
<p>- David</p>
<br />
<p>On May 15th, 2013, 7:39 p.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 7:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows users to prevent important items from being overwritten in the clipboard history.
Methods keep and setKeep were added to HistoryItem. If an item has keep set to true, it will not be overwritten.
A submenu was added to set whether an item should be kept in history.
Even if there are more elements in the list than the maximum number of entries, the newest element copied to the clipboard will be in the clipboard item.
In order to allow Klipper to read history files written with previous versions of Klipper, saving and loading if an item should be kept is handled in klipper.cpp and not by the item.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=54212">54212</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/history.cpp <span style="color: grey">(49e9bb0)</span></li>
<li>klipper/historyitem.h <span style="color: grey">(6c41d5d)</span></li>
<li>klipper/historyitem.cpp <span style="color: grey">(21fbe4e)</span></li>
<li>klipper/klipper.h <span style="color: grey">(bbfd9c9)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(cf41bd2)</span></li>
<li>klipper/klipperpopup.h <span style="color: grey">(31beff2)</span></li>
<li>klipper/klipperpopup.cpp <span style="color: grey">(bff2c25)</span></li>
<li>klipper/popupproxy.h <span style="color: grey">(910bd6e)</span></li>
<li>klipper/popupproxy.cpp <span style="color: grey">(555f383)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>