K(Abstract)FileItemActionPlugin

[Frank Reininghaus]

Hi Sune,

2013/6/20 Sune Vuorela:
>>> so Frank, please, pretty please, can you reconsider?
>>
>> I see that Ivan rewrote the plugin and that it does at least not do
>> anything fishy any more before the context menu is shown. I also
>> understand that people who do not have to deal with the bug reports
>> mess and only see the possible benefits of the plugins don't like my
>> proposal to disable all plugins by default.
>
> I haven't - yet - seen such bug reports, but that's mostly because we
> are a bit behind in Debian. I'm sure that, if it wasn't fixed, I would
> have recieved multiple bug reports there about the issue.
>
> And I'm pretty sure that most people active in this thread has seen the
> downsides of plugins or at least thought about them.
>
>> So yes, I am willing to
>> reconsider, and I don't mind if the ugly workaround is removed before
>> the API freeze. But I'd appreciate it if someone else (Sune maybe?)
>> could make the changes in the three repositories. I have wasted so
>
> If you want, I can allocate the time tonight to remove the workaround in
> the ~three repositories.

That would be great. I don't really know when will be the next time
I'm at home in front of the computer with some spare time, and I still
have quite a few patches of mine that are now tested by others and
have to be rebased and pushed.

The workaround commits to be undone are (all in the master branch):

http://quickgit.kde.org/?p=kactivities.git&a=commit&h=e87f922096e7c1a571a6ee7ed20599210559ad4d
http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=b1aebb44d6863951841d857b84253a782d4138dc
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=b97dad72c39edd27450e999b8042e1d7e85231a3

Thanks for your help and best regards,
Frank