Review Request 111054: allow <imageobjectco> to be used in KDE Documentation

T.C. Hollingsworth tchollingsworth at gmail.com
Tue Jun 18 01:20:31 BST 2013



> On June 17, 2013, 9:24 p.m., Luigi Toscano wrote:
> > imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be included by mediaobjectco, which is not ignored but required for the maps. The patch removes the imageobjectco.module from the set of ignored modules, so go for it.
> > 
> > Is it for master?
> 
> Luigi Toscano wrote:
>     Ups, I didn't see "KDE/4.10". But we are going for 4.11 now, is it for 4.11 or post-4.11?
>     
>     For more reference on imageobjectco, http://www.docbook.org/tdg/en/html/imageobjectco.html
> 
> T.C. Hollingsworth wrote:
>     I thought master was frozen and the stable branch was the only way to get anything into kdelibs?
>     
>     In fact, we have a couple docs that didn't go into kdelibs for just this reason:
>     http://lists.kde.org/?l=kde-doc-english&m=132839141213685&w=2
> 
> Luigi Toscano wrote:
>     Yes, master is still 4.11; I just thought that we were already past the 4.11 documentation freeze, but we are not (July 8). I guess you are planning to merge your work branch before that.

Yup; I'm hoping to have it ready for review by the rest of the team later this week.

Thanks for the quick review, Luigi!  :-)


- T.C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111054/#review34535
-----------------------------------------------------------


On June 17, 2013, 2:12 a.m., T.C. Hollingsworth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111054/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 2:12 a.m.)
> 
> 
> Review request for Documentation, kdelibs and Luigi Toscano.
> 
> 
> Description
> -------
> 
> allow <imageobjectco> to be used in KDE Documentation
> 
> it is needed to allow imagemaps to work without checkXML errors for the Visual Dictionary in the KDE Fundamentals documentation
> 
> 
> Diffs
> -----
> 
>   kdoctools/customization/dtd/rdbpool.elements 3ac2670 
> 
> Diff: http://git.reviewboard.kde.org/r/111054/diff/
> 
> 
> Testing
> -------
> 
> Made this change in /usr/share/kde4/apps/ksgmltools2/ and saw the checkXML error go away when building the draft fundamentals documentation in branches/work/doc.
> 
> 
> Thanks,
> 
> T.C. Hollingsworth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130618/2bd71faa/attachment.htm>


More information about the kde-core-devel mailing list