<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111054/">http://git.reviewboard.kde.org/r/111054/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 17th, 2013, 9:24 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">imageobjectco, supported since the Paleolitic age in DocBook 4.x, can be included by mediaobjectco, which is not ignored but required for the maps. The patch removes the imageobjectco.module from the set of ignored modules, so go for it.
Is it for master?</pre>
</blockquote>
<p>On June 17th, 2013, 9:26 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ups, I didn't see "KDE/4.10". But we are going for 4.11 now, is it for 4.11 or post-4.11?
For more reference on imageobjectco, http://www.docbook.org/tdg/en/html/imageobjectco.html</pre>
</blockquote>
<p>On June 17th, 2013, 10:35 p.m. UTC, <b>T.C. Hollingsworth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought master was frozen and the stable branch was the only way to get anything into kdelibs?
In fact, we have a couple docs that didn't go into kdelibs for just this reason:
http://lists.kde.org/?l=kde-doc-english&m=132839141213685&w=2</pre>
</blockquote>
<p>On June 17th, 2013, 10:54 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, master is still 4.11; I just thought that we were already past the 4.11 documentation freeze, but we are not (July 8). I guess you are planning to merge your work branch before that.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup; I'm hoping to have it ready for review by the rest of the team later this week.
Thanks for the quick review, Luigi! :-)</pre>
<br />
<p>- T.C.</p>
<br />
<p>On June 17th, 2013, 2:12 a.m. UTC, T.C. Hollingsworth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation, kdelibs and Luigi Toscano.</div>
<div>By T.C. Hollingsworth.</div>
<p style="color: grey;"><i>Updated June 17, 2013, 2:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">allow <imageobjectco> to be used in KDE Documentation
it is needed to allow imagemaps to work without checkXML errors for the Visual Dictionary in the KDE Fundamentals documentation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made this change in /usr/share/kde4/apps/ksgmltools2/ and saw the checkXML error go away when building the draft fundamentals documentation in branches/work/doc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdoctools/customization/dtd/rdbpool.elements <span style="color: grey">(3ac2670)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111054/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>