Review Request 106300: add kimgio WebP image format plugin

[Christoph Feck]

> On May 18, 2013, 12:44 p.m., Commit Hook wrote:
> > This review has been submitted with commit df845b06bc440fff5a43a9cdc149e8c88c29bc67 by Martin Koller to branch master.
> 
> Christoph Feck wrote:
>     Just noticed this has been committed to kolourpaint instead of kdelibs. Did I miss a discussion about this change?
> 
> Albert Astals Cid wrote:
>     If you addressed Allan's comment i'd sincerely put it where it belongs, which is obviously not kolourpaint :D

This still is only in kolourpaint, which is unfortunate. Bug 267365 is a KDE general feature request. People who do not install kolourpaint will be left out.

Additionally, having it installed will make it work with other Qt programs (Gwenview etc.), but not the thumbnailer. I cannot add the mime type to the thumbnailer, if the plugin is only in kolourpaint.

AFAIK, it was decided to move it to kde-runtime.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106300/#review32734
-----------------------------------------------------------


On May 26, 2013, 12:12 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106300/
> -----------------------------------------------------------
> 
> (Updated May 26, 2013, 12:12 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch adds support for the new Google invented WebP image format. See https://developers.google.com/speed/webp/?hl=ru
> 
> 
> This addresses bug 267365.
>     http://bugs.kde.org/show_bug.cgi?id=267365
> 
> 
> Diffs
> -----
> 
>   kimgio/CMakeLists.txt 26329c0 
>   kimgio/webp.cpp PRE-CREATION 
>   kimgio/webp.desktop PRE-CREATION 
>   kimgio/webp.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106300/diff/
> 
> 
> Testing
> -------
> 
> some KDE apps, including read/write with a modified kolourpaint (to be able to change the quality)
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130616/9ce480cb/attachment.htm>