Review Request 111042: Upstream SUSE specific changes and introduce a DISTRO switch to enable

[Luca Beltrame]

> On June 15, 2013, 6:52 p.m., Luca Beltrame wrote:
> > I would like to chime in, since I'm also a member of the openSUSE community KDE team. This patch and the idea behind it is *not* the official position of openSUSE, nor the official position of the openSUSE community KDE team. It is way too specific and added complexity for no apparent gain.
> > We have in mind of upstreaming patches were possible, but not like this.
> > 
> > Also:
> > 
> > - ksuseinstall is actually on its way to be *killed* in future openSUSE versions.
> > - Stuff like YMP handlers (one-click installs) 
> > - The patch is *broken* in many ways, including adding debug areas for non shipped software (kupdateapplet), a lot of needless compatibility layers (KDE3) etc. It's just a wholesale port made without any serious efforts at reviewing.
> > 
> > Some of these applications have also long outstanding issues that no one will fix (because the original developers moved on and there was no one to replace them). Putting unmaintained and broken code in KDE git (and I say this with *both* my KDE and distro hats on) is a no-no.
> > 
> > Definitely -1, on behalf of the team (myself, Raymond "tittiatcoke" Wooninck and Hrvoje "shumski" Senjan").

> - Stuff like YMP handlers (one-click installs) 

That is meant to be read as "Stuff like YMP handlers (one-click installs) have no place in upstream KDE".


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111042/#review34392
-----------------------------------------------------------


On June 15, 2013, 4:27 p.m., Johannes Obermayr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111042/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 4:27 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Distributions should upstream their patches / changes:
> - Upstream / other distributions can easily see distro specific changes and enable them by default by removing "#if defined(DISTRO_xxx)"
> - Maybe duplicate work can be avoided and other distributions can easily use them by "|| defined(DISTRO_xxx)"
> - Less adaptions of downstream patches ...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 705c84e 
>   kdecore/config/kconfig.cpp 048605d 
>   kdecore/config/kconfig_p.h 7751242 
>   kdecore/config/kconfigdata.h e5dd7da 
>   kdecore/config/kconfiggroup.h 8eddfd5 
>   kdecore/config/kconfiggroup.cpp 9e73eb7 
>   kdecore/config/kdesktopfile.h 1c4eae6 
>   kdecore/config/kdesktopfile.cpp 54e5910 
>   kdecore/kdebug.areas 29a4415 
>   kdecore/localization/klocale_kde.cpp b010e74 
>   kdecore/services/kservice.h 3843bad 
>   kdecore/services/kservice.cpp e2cc86f 
>   kdecore/services/kservicegroup.h 9fdf2b0 
>   kdecore/services/kservicegroup.cpp 08bc587 
>   kdecore/services/kservicegroup_p.h 5f21497 
>   kded/vfolder_menu.cpp f0b0b35 
>   kdesu/defaults.h 706a088 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   khtml/html/html_objectimpl.cpp f0f590d 
>   kio/CMakeLists.txt 4854829 
>   kio/kio/kprotocolmanager.cpp 05bb547 
>   kio/kio/krun.cpp ad5656e 
>   kjs/collector.cpp cdd8421 
>   plasma/containment.h e725a99 
>   plasma/containment.cpp fc2ca70 
>   plasma/private/containment_p.h 75a6f80 
>   plasma/theme.cpp 4554de7 
>   suseinstall/CMakeLists.txt PRE-CREATION 
>   suseinstall/kbuildsycocaprogressdialog.h PRE-CREATION 
>   suseinstall/kbuildsycocaprogressdialog.cpp PRE-CREATION 
>   suseinstall/ksuseinstall.h PRE-CREATION 
>   suseinstall/ksuseinstall.cpp PRE-CREATION 
>   suseinstall/ksuseinstall_export.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Johannes Obermayr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130615/61956739/attachment.htm>