Review Request 110894: Add missing error mapping to KTcpSocket
Albert Astals Cid
aacid at kde.org
Tue Jun 11 16:13:36 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110894/#review34150
-----------------------------------------------------------
You forgot the @since 4.10.5 marker and also to merge to master. I'll do the merge but i'd appreciate if you fixed the docu adding when the enum was introduced.
- Albert Astals Cid
On June 11, 2013, 12:35 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110894/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 12:35 p.m.)
>
>
> Review request for kdelibs and Andreas Hartmetz.
>
>
> Description
> -------
>
> Add missing error mapping for SslHandshakeFailedError to KTcpSocket.
>
>
> Diffs
> -----
>
> kdecore/network/ktcpsocket.h 58dfa2c
> kdecore/network/ktcpsocket.cpp 1a64d9d
>
> Diff: http://git.reviewboard.kde.org/r/110894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130611/06446531/attachment.htm>
More information about the kde-core-devel
mailing list