Review Request 110894: Add missing error mapping to KTcpSocket
Martin Bříza
mbriza at redhat.com
Tue Jun 11 14:20:08 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110894/#review34144
-----------------------------------------------------------
Thank you, Dawit!
What about the other signals which were added over time and aren't included and mapped in the class? I mean the UnfinishedSocketOperationError and every Proxy error except the ProxyAuthenticationRequiredError. Seems they shouldn't be needed but just to be sure.
- Martin Bříza
On June 11, 2013, 12:35 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110894/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 12:35 p.m.)
>
>
> Review request for kdelibs and Andreas Hartmetz.
>
>
> Description
> -------
>
> Add missing error mapping for SslHandshakeFailedError to KTcpSocket.
>
>
> Diffs
> -----
>
> kdecore/network/ktcpsocket.h 58dfa2c
> kdecore/network/ktcpsocket.cpp 1a64d9d
>
> Diff: http://git.reviewboard.kde.org/r/110894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130611/d805e130/attachment.htm>
More information about the kde-core-devel
mailing list