Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

[Emmanuel Pescosta]

> On June 10, 2013, 8:26 a.m., David Faure wrote:
> > I don't like the duplication very much (can't the old method call the V2 method, if the only difference is the return value, which the old method would then ignore?).
> > 
> > Otherwise OK, as it's kind of temporary anyway. It just increases the risks of someone fixing a bug in one copy and not the other, so if we can avoid the duplication, it's better.
> 
> Emmanuel Pescosta wrote:
>     > can't the old method call the V2 method, if the only difference is the return value, which the old method would then ignore?
>     Yes this makes sense. I will change it.
>     
>     Btw.: What does BIC mean? - I only know the definition 'bank identifier code'.
> 
> David Faure wrote:
>     BIC = binary incompatible change

Thanks for the explanation :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110922/#review34017
-----------------------------------------------------------


On June 10, 2013, 9:22 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110922/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:22 a.m.)
> 
> 
> Review request for Dolphin, KDE Base Apps, David Faure, and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Change the data in the model before the real renaming is done by KonqOperations::rename(),
> but when the rename operation fails, revert the data changes in the model.
> 
> The problem is that DolphinView::slotRoleEditingFinished() changes the data in the model *before* the actual renaming is performed by KonqOperations/KIO.
> But we need this approach for the following cases:
> * Immediate feedback from the users point of view (No delay between finish renaming and DolphinView updates)
> * Missing file system/dir lister signals, when there is no file system notification system (ftp, ssh, ...)
> 
> A lot of code in konq_operations.h and konq_operations.cpp is just copy and paste, to guarantee binary compatibility. (added some TODOs for KF 5.0)
> 
> 
> This addresses bug 319119.
>     http://bugs.kde.org/show_bug.cgi?id=319119
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 5a70c55 
>   dolphin/src/views/dolphinview.cpp 9a4b863 
>   lib/konq/konq_operations.h a9aec89 
>   lib/konq/konq_operations.cpp cbb058c 
> 
> Diff: http://git.reviewboard.kde.org/r/110922/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> Tested with a remote ssh file system on a virtual machine.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130610/dea45362/attachment.htm>