Review Request 110898: Remove unused strigi dependency from tree, along with unused strigi FontAnalyzer.

Michael Pyne mpyne at kde.org
Sun Jun 9 20:28:13 BST 2013


On Sun, June 9, 2013 16:11:27 Simeon Bird wrote:
> > On June 9, 2013, 10:27 a.m., Albert Astals Cid wrote:
> > > Being past the Feature Freeze doesn't seem a good idea to me to remove a
> > > feature.
> It isn't really removing a feature - the code in question does nothing at
> all that I can see, and hasn't done for a while. In fact, I'm not sure the
> FontAnalyzer really did anything even when strigi was in use, because
> /usr/share/fonts was not indexed by default. Its just removing dead code.
> 
> It *is* a dependency change though, and I'm not sure what the rules are for
> that. I guess it could be made optional, but since it doesn't do anything
> that doesn't seem really worth the effort.

Speaking just to the dependency change, my feeling is that it's always 
acceptable to remove a dependency. It would not be acceptable to add or 
upgrade a dependency after the dep. freeze though.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130609/4004c9bc/attachment.sig>


More information about the kde-core-devel mailing list