Review Request 111795: Remove three character restriction on the services runner

[Milo Mordaunt]

> On July 30, 2013, 1:54 p.m., Aaron J. Seigo wrote:
> > plasma/generic/runners/services/servicerunner.cpp, lines 109-117
> > <http://git.reviewboard.kde.org/r/111795/diff/1/?file=175310#file175310line109>
> >
> >     i would move this down to line 129 and make the "if (service->name().contains.." line down there an "else if" to this. that way these comparisons are all done in the same place and only done once.

Ah OK, you already fixed it :P! 

Thanks for the help, I'm sure this won't be the last contribution....


- Milo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111795/#review36810
-----------------------------------------------------------


On July 30, 2013, 2:03 p.m., Milo Mordaunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111795/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 2:03 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> The services runner now queries with terms of less than three characters.
> 
> Previously with a term of less than three characters this runner would be idle. Now it gives more immediate results, ie gp now returns gparted., and since it is only the services runner they are likely to be relevant.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/services/servicerunner.cpp 7b292efe40bbddb23cfc317648db0e645c579879 
> 
> Diff: http://git.reviewboard.kde.org/r/111795/diff/
> 
> 
> Testing
> -------
> 
> I have tested a variety of terms in my krunner, and the services runner appears to be working as expected.
> 
> 
> Thanks,
> 
> Milo Mordaunt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130730/033b0c20/attachment.htm>