Review Request 111795: Remove three character restriction on the services runner

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111795/#review36810
-----------------------------------------------------------

Ship it!


one small issue below, easily resolved by simply moving the code down a few lines and then this can go in.

I'll push this right now, in fact, with the issues fixed.

Thanks for the patch Milo, and congrats on your first code contribution! Be careful: If you make this a habit, we'll end up making you get a commit account ;)


plasma/generic/runners/services/servicerunner.cpp
<http://git.reviewboard.kde.org/r/111795/#comment27161>

    i would move this down to line 129 and make the "if (service->name().contains.." line down there an "else if" to this. that way these comparisons are all done in the same place and only done once.


- Aaron J. Seigo


On July 30, 2013, 12:46 p.m., Milo Mordaunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111795/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 12:46 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> The services runner now queries with terms of less than three characters.
> 
> Previously with a term of less than three characters this runner would be idle. Now it gives more immediate results, ie gp now returns gparted., and since it is only the services runner they are likely to be relevant.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/services/servicerunner.cpp 7b292efe40bbddb23cfc317648db0e645c579879 
> 
> Diff: http://git.reviewboard.kde.org/r/111795/diff/
> 
> 
> Testing
> -------
> 
> I have tested a variety of terms in my krunner, and the services runner appears to be working as expected.
> 
> 
> Thanks,
> 
> Milo Mordaunt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130730/e23cfa25/attachment.htm>