Review Request 111341: Oxygenify KNetattach

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111341/#review35762
-----------------------------------------------------------


The patch is wrong.

It is correct for knetattach to have an own icon and to use it its own code. If you want an Oxygen version of this icon, then create one (named "knetattach") and add it to the Oxygen icon theme, which will be used automatically when the icon theme in use is Oxygen (or a derived from it which not carries an own version of the knetattach icon).

- Pino Toscano


On July 1, 2013, 3:12 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111341/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 3:12 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?
> 
> 
> Diffs
> -----
> 
>   knetattach/knetattach.cpp 3d348c1 
>   knetattach/knetattach.desktop 2684602 
> 
> Diff: http://git.reviewboard.kde.org/r/111341/diff/
> 
> 
> Testing
> -------
> 
> Works fine for quite some time on Kubuntu.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130708/7d6e6ad9/attachment.htm>