Review Request 111341: Oxygenify KNetattach

[Rohan Garg]

> On July 2, 2013, 1:32 a.m., Thomas Lübking wrote:
> > Looks like the proper source, but i guess the icon should be rather replaced so that any user of knetattach (eg. a local .desktop file) gets the updated variant.
> > 
> > Please attach Nuno to the review as the icons are his domain ;-)
> 
> Rohan Garg wrote:
>     RB can't seem to find Nuno. Though I've pinged him with the RB link on IRC, I have yet to get a reply.

Bump? I agree with the fact that we should replace the icons so that any local desktop files get the change.


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111341/#review35402
-----------------------------------------------------------


On July 1, 2013, 8:42 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111341/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 8:42 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?
> 
> 
> Diffs
> -----
> 
>   knetattach/knetattach.cpp 3d348c1 
>   knetattach/knetattach.desktop 2684602 
> 
> Diff: http://git.reviewboard.kde.org/r/111341/diff/
> 
> 
> Testing
> -------
> 
> Works fine for quite some time on Kubuntu.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130708/dd9c1c74/attachment.htm>