Review Request 111341: Oxygenify KNetattach

Rohan Garg rohangarg at kubuntu.org
Mon Jul 1 16:12:11 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111341/
-----------------------------------------------------------

(Updated July 1, 2013, 8:42 p.m.)


Review request for KDE Runtime.


Changes
-------

Asked Nuno to have a look at this request, on his suggestion, I've changed the icon to network-workgroup.


Description
-------

Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?


Diffs (updated)
-----

  knetattach/knetattach.cpp 3d348c1 
  knetattach/knetattach.desktop 2684602 

Diff: http://git.reviewboard.kde.org/r/111341/diff/


Testing
-------

Works fine for quite some time on Kubuntu.


Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130701/865849c7/attachment.htm>


More information about the kde-core-devel mailing list