Review Request 111341: Oxygenify KNetattach

Thomas Lübking thomas.luebking at gmail.com
Mon Jul 1 14:01:33 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111341/#review35352
-----------------------------------------------------------



knetattach/knetattach.cpp
<http://git.reviewboard.kde.org/r/111341/#comment25903>

    Seems wrong. Have you had contact to the oxygen artists (ie. esp. Nuno)?


- Thomas Lübking


On July 1, 2013, 11:20 a.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111341/
> -----------------------------------------------------------
> 
> (Updated July 1, 2013, 11:20 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Patch from Kubuntu packages that oxygenifies the KNetattach icon. The current icon is from the KDE 3 era and should be updated. Maybe it's also worth dropping the old icons from the knetattach folder?
> 
> 
> Diffs
> -----
> 
>   knetattach/knetattach.cpp 3d348c1 
>   knetattach/knetattach.desktop 2684602 
> 
> Diff: http://git.reviewboard.kde.org/r/111341/diff/
> 
> 
> Testing
> -------
> 
> Works fine for quite some time on Kubuntu.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130701/62451e67/attachment.htm>


More information about the kde-core-devel mailing list