Review Request 108637: Fix KColorButton change color + cancel behaviour

Albert Astals Cid aacid at
Mon Jan 28 00:27:08 GMT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Laurent Montel.


Do not connect colorSelected to _k_colorChosen otherwise two bad things happen:
 a) Selecting a color and canceling still changes the color of the color button (this is KColorButtonTest::testChangeAndCancel that fails without my change)
 b) If you are in Recent Colors there's a crash (bug 313984 because a lot of bad things happen (this is not in my tests, will add later if you guys agree this is the correct fix))

Laurent added
     connect(dialog, SIGNAL(colorSelected(QColor)), q, SLOT(_k_colorChosen()));
to make sure that double click worked, thus i've added KColorButtonTest::testDoubleClickChange() to prove it still works after my change


Developed against master, plan to apply against KDE/4.10 too


  kdeui/colors/kcolorbutton.cpp 786cb9d 
  kdeui/tests/CMakeLists.txt 85f12ed 
  kdeui/tests/kcolorbuttontest.h PRE-CREATION 
  kdeui/tests/kcolorbuttontest.cpp PRE-CREATION 



Okular no longer crashes, the tests


Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list