Review Request 104746: kjs: Implement Object.isExtensible and Object.preventExtensible

Bernd Buschinski b.buschinski at googlemail.com
Tue Jan 22 03:12:05 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104746/
-----------------------------------------------------------

(Updated Jan. 22, 2013, 3:12 a.m.)


Review request for kdelibs.


Changes
-------

- Rebase on KDE/4.10 and update to current API.
- Get rid of toString calls in exceptions messages which could also throw an exception


Description
-------

kjs: Implement Object.isExtensible and Object.preventExtensible

Also imeplement the changes nesseary to correctly behave on isExtensible or not.
-> allow chaning the value of already existing property, do not allow adding new property.


Diffs (updated)
-----

  kjs/array_instance.cpp 2469316 
  kjs/object.h 9446349 
  kjs/object.cpp 9249902 
  kjs/object_object.cpp 39161e2 
  kjs/property_map.h a41736a 

Diff: http://git.reviewboard.kde.org/r/104746/diff/


Testing
-------

ecmascript 15.2.3.13* test


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130122/bcb829f4/attachment.htm>


More information about the kde-core-devel mailing list