Review Request 107409: [KMenuEdit] Ability to sort elements

[Julien Borderie]

> On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote:
> > Quick question, this sorting does affect only the view of kmenuedit or affects also the K-menu?

Yes, it affects the KMenu.
I updated description and test cases.


> On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote:
> > kmenuedit/treeview.cpp, line 238
> > <http://git.reviewboard.kde.org/r/107409/diff/2/?file=107708#file107708line238>
> >
> >     Why these new connects for cut, copy, etc?
> >     Oh, i see you moved them up
> >     
> >     It would be good if you could make the minimum changes to the patch, i.e. those only related to the feature itslf, does't seem you need moving those connects, right? If so, don't do it

No problem, it was just for connect centralization. I reverted it.


> On Jan. 19, 2013, 5 p.m., Albert Astals Cid wrote:
> > kmenuedit/treeview.h, line 147
> > <http://git.reviewboard.kde.org/r/107409/diff/2/?file=107707#file107707line147>
> >
> >     This should be SortType not and int

Absolutely, but this slot is called from the QSignalMapper, and I can't directly connect the signal "mapped(int)" to the slot "sort(SortType)".
A solution should be using an intermediary slot, which calls "sort(SortType)", but is it not ugly ? :p


- Julien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107409/#review25800
-----------------------------------------------------------


On Jan. 19, 2013, 10:09 p.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107409/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10:09 p.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to sort items in KMenuEdit (by name or description) :
> - sort sub-elements for the current selection.
> - sort all elements.
> 
> Particularities :
> - It respects separator elements to avoid mixing elements groups together.
> - Actions are available in the main menu, toolbar and contextual menu.
> - Once saved, changes also visible in the K menu.
> - Recursive sort.
> - Selection sorting is disabled if the selection is empty or is not a menu.
> 
> Thank you for your review.
> 
> 
> This addresses bug 108419.
>     http://bugs.kde.org/show_bug.cgi?id=108419
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 6a0506b 
>   kmenuedit/kmenueditui.rc 273847d 
>   kmenuedit/main.cpp 65efdf9 
>   kmenuedit/treeview.h 0284584 
>   kmenuedit/treeview.cpp b144b1c 
> 
> Diff: http://git.reviewboard.kde.org/r/107409/diff/
> 
> 
> Testing
> -------
> 
> If started KMenuEdit does not make part of the running KDE version, these following test cases require to make a kbuildsycoca4 to be visible in the current K menu.
> 
> 1) Sort element by name
> - Select an element
> - Choose "sort by name" --> item children sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted children
> 
> 2) Sort element by description
> - Select an element
> - Choose "sort by description" --> item children sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted children
> 
> 3) Sort all by name
> - Choose "sort all by name" --> all items sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted items
> 
> 4) Sort all by description
> - Choose "sort all by description" --> all items sorted
> - Now save (and kbuildsycoca4) --> kmenu displays sorted items
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130119/b3bb8c05/attachment.htm>