Review Request 107409: [KMenuEdit] Ability to sort elements

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107409/#review25800
-----------------------------------------------------------


Quick question, this sorting does affect only the view of kmenuedit or affects also the K-menu? 


kmenuedit/treeview.h
<http://git.reviewboard.kde.org/r/107409/#comment19715>

    This should be SortType not and int



kmenuedit/treeview.cpp
<http://git.reviewboard.kde.org/r/107409/#comment19716>

    Why these new connects for cut, copy, etc?
    Oh, i see you moved them up
    
    It would be good if you could make the minimum changes to the patch, i.e. those only related to the feature itslf, does't seem you need moving those connects, right? If so, don't do it


- Albert Astals Cid


On Jan. 18, 2013, 9:27 a.m., Julien Borderie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107409/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 9:27 a.m.)
> 
> 
> Review request for kde-workspace and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> Hi,
> 
> This patch adds 2 actions to sort items in KMenuEdit (by name or description) :
> - sort sub-elements for the current selection.
> - sort all elements.
> 
> It respects separator elements to avoid mixing elements groups together.
> Actions are visible in the main menu, toolbar and contextual menu.
> 
> Thank you for your review.
> 
> 
> This addresses bug 108419.
>     http://bugs.kde.org/show_bug.cgi?id=108419
> 
> 
> Diffs
> -----
> 
>   kmenuedit/kmenuedit.cpp 6a0506b 
>   kmenuedit/kmenueditui.rc 273847d 
>   kmenuedit/main.cpp 65efdf9 
>   kmenuedit/treeview.h 0284584 
>   kmenuedit/treeview.cpp b144b1c 
> 
> Diff: http://git.reviewboard.kde.org/r/107409/diff/
> 
> 
> Testing
> -------
> 
> - Select an element and choose "sort by name".
> - Select an element and choose "sort by description".
> - Choose "sort all by name".
> - Choose "sort all by description".
> - Select an empty menu or a simple element -> selection sorting disabled.
> 
> 
> Thanks,
> 
> Julien Borderie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130119/74807b39/attachment.htm>